The new TextField (Incubator)

[ethanshar]

Recreate the TextField component basing on these guidelines

• Add parity with the old TextField
• Use ThemeManager to apply our private UI
• QA the component for missing functionality and UI issues
• Start planning a migration process

Features

• General structure
• Support floating placeholder
• Refine floating placeholder behavior (support custom typography, add scale animation)
• Support accessory buttons
• Support style per state (focused, invalid, disabled, blur)
• Allow styling Label
• Allow styling ValidationMessage
• Connect to validation logic
• Support checking validation in blur, change, state
• Consider adding presets for different UI looks
• Fix Android spacing issues, make sure UI is aligned between the two Platforms
• Support char counter
• Support helper text (renamed to hint)
• Support render validation message on top/bottom
• Support multiline
• Verify controlled behavior
• Support Accessibility
• Fix ref warning
• Fix typescript errors
• Support theme props
• RTL

Notes for Review

• The reason for this reimplementation is the fact this component contains legacy code which is impossible to maintain today
• There are lots of files to go over, no need to review generatedTypes files
• In the new implementation I broke the component into very smaller components, each with a specific purpose.
  It should be much more readable to go over the code. And in general that's how I see we should write complex components.
• I decided to omit specific UI/Functionality decisions that are internal to the Wix App in order to make the component more generic. We should be able to customize everything using ThemeManager.
• There are spacing differences between Android and iOS which are impossible to unify (height of the input for example) and
  I decided not to fix them - I believe fixing them lead us to lots of repeating spacings issues.

[egorshulga]

Hey guys! I found out TextField is typed as any in the current release. Would this PR just replace the old one, would new TextField have correct typings, so it would be unnecessary to fix the old one?

[ethanshar]

Hi @egorshulga
Yes, once released the new TextField will include typings and better API overall.

[Inbal-Tish]

Do you want to revert the change here and keep it optional?

[ethanshar]

Changed it back to optional
and moved the check for maxLength to CharCounter