Demo screen support injected ui #855
Conversation
|
@mendyEdri When and if this ready, assign me as a reviewer 👍 |
…emo settings screen
with ability to controll the 'refresh app' message as a prop
mendyEdri
force-pushed
the
demo-screen-support-injected-ui
branch
from
eda388f to
9440b8c
Compare
demo/src/screens/MainScreen.js
Outdated
| shouldComponentUpdate = (nextProps, nextState) => { | ||
| this.updateShowRefreshAppMessage(nextProps.showRefreshAppMessage); | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
This will be called before each render.
Not sure that's the right way to do that..
shouldComponentUpdate is meant to have calculation regarding whether the component should render or not.
If anything you probably want to move this part of code to componentDidUpdate .
Anyway, maybe there's a better way to trigger a toast from the private repo..
I think the wiring here is a little more complicated then is should be.
There was a problem hiding this comment.
componentDidUpdate - gotcha.
@ethanshar Triggering the toast from the private repo - you mean that the toast should be rendered in the private repo?
or some different - easier wiring?
There was a problem hiding this comment.
Yes, something like that.
In the private repo we have an infrastructure for trigger Toast from anywhere in the code, we call it global toast.
It's a functionality we offer to One App and we use it ourselves in the demo app. so it might easier for you to use that..
Search in the private repo for "toggleToast" in the MainScreen.
demo/src/screens/SettingsScreen.js
Outdated
| @@ -15,9 +14,11 @@ class SettingsScreen extends Component { | |||
|
|
|||
| const data = props.navigationData || navigationData; | |||
| const playground = props.playground || playgroundScreen; | |||
|
|
|||
| const extraSettingsUI = props.extraSettingsUI; | |||
There was a problem hiding this comment.
This part is also redundant, no need to store this prop in state cause we're rendering it directly from props.
Added support for the demo screen to have injected UI as extra settings.