Drawer - trigger onToggleSwipeLeft on releases #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jul 21, 2020
src/components/drawer/Swipeable.tsx
Outdated
| @@ -303,8 +303,8 @@ export default class Swipeable extends Component<PropType, StateType> { | |||
| } | |||
| }); | |||
|
|
|||
| if (toValue === rowWidth * LEFT_TOGGLE_THRESHOLD && onToggleSwipeLeft) { | |||
| onToggleSwipeLeft({rowWidth, leftWidth}); | |||
| if ((toValue === rowWidth * LEFT_TOGGLE_THRESHOLD || this.dragFired) && onToggleSwipeLeft) { | |||
There was a problem hiding this comment.
At first I wasn't sure where this comes from (this.dragFired) I think the PR is missing some of the code changes.
Anyway, the name of the variable was a little confusing to me.
Is the flag purpose is to mark when the drag exceed threshold? if so, consider renaming it..
|
@ethanshar This is a second PR for this ticket. The first was merged and this is the changes UX ask for so maybe that's why you think some of the changes are not showing in the code? |
ethanshar
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for trigger event on release instead of just threshold