Migrate Drawer to TS #861
Merged
Migrate Drawer to TS #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jul 22, 2020
| /** | ||
| * Style | ||
| */ | ||
| style: ViewStyle; |
There was a problem hiding this comment.
Style is not optional?
Inbal-Tish
reviewed
Jul 22, 2020
| * with gestureHandlerRootHOC from 'react-native-gesture-handler'. see | ||
| * @importantLink: https://kmagiera.github.io/react-native-gesture-handler/docs/getting-started.html#with-wix-react-native-navigation-https-githubcom-wix-react-native-navigation | ||
| */ | ||
| declare class NewDrawer extends PureComponent<DrawerProps> { |
There was a problem hiding this comment.
This class should be renamed, no?
Inbal-Tish
reviewed
Jul 22, 2020
src/components/drawer/index.tsx
Outdated
| /** | ||
| * Style | ||
| */ | ||
| style: ViewStyle; |
Inbal-Tish
reviewed
Jul 22, 2020
src/components/drawer/index.tsx
Outdated
| if (items) { | ||
| return ( | ||
| <View animated row style={{transform: [{translateX: this.leftActionX}]}}> | ||
| {_.map(items, (item, index) => { | ||
| <View animated row style={{transform: [{translateX: this.leftActionX}]} as any as ViewStyle}> |
There was a problem hiding this comment.
Why you need ' as any as ViewStyle' here?
There was a problem hiding this comment.
TBH, not sure why it's even giving me an error.
This is a trick I learned from the guys from Kiev.
First you cast to any and from there you can cast to anything you want.
Not a fan of this solution. another option is to explicitly ts-ignore this line and revisit in the future.
WDYT?
There was a problem hiding this comment.
I would ts-ignore it, the casting seems redundant and expensive
Inbal-Tish
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed minor issue with drawer toggle invocation. (What I sent you in slack)