Skip to content

add border radius to badge #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2020
Merged

add border radius to badge #865

merged 3 commits into from
Jul 30, 2020

Conversation

lidord-wix
Copy link
Contributor

No description provided.

@lidord-wix lidord-wix requested a review from ArnonZ July 26, 2020 14:33
@lidord-wix lidord-wix assigned lidord-wix and ArnonZ and unassigned lidord-wix Jul 26, 2020
ArnonZ
ArnonZ reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ArnonZ ArnonZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the relevant ticket to the PR description so it's clear what the request was which prompted this change.

ArnonZ
ArnonZ reviewed Jul 29, 2020
View reviewed changes
ArnonZ
ArnonZ reviewed Jul 29, 2020
View reviewed changes
ArnonZ
ArnonZ reviewed Jul 29, 2020
View reviewed changes
ArnonZ
ArnonZ suggested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ArnonZ ArnonZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See one last issue mentioned above.

@ArnonZ ArnonZ self-requested a review July 30, 2020 10:26
@ArnonZ ArnonZ merged commit 1189046 into master Jul 30, 2020
@lidord-wix lidord-wix deleted the feat/badge_radius branch August 4, 2020 15:14
@lidord-wix lidord-wix mentioned this pull request Sep 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar left review comments

@ArnonZ ArnonZ ArnonZ approved these changes

Assignees

@ArnonZ ArnonZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidord-wix @ethanshar @ArnonZ