Skip to content

withScrollReached - fix Android threshold #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 6, 2020
Merged

withScrollReached - fix Android threshold #878

merged 5 commits into from
Aug 6, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

No description provided.

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar August 3, 2020 15:30
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
Feel free to push minor changes like these directly to master

ethanshar
ethanshar approved these changes Aug 4, 2020
View reviewed changes
@M-i-k-e-l @ethanshar
Update src/commons/withScrollReached.tsx
7ec7f05 
Change import

Co-authored-by: Ethan Sharabi <[email protected]>
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
There are conflicts here..
you can fix them and merge

@M-i-k-e-l M-i-k-e-l merged commit a84bdd5 into master Aug 6, 2020
@M-i-k-e-l M-i-k-e-l deleted the fix/with-scroll-reached-android-threshold branch September 21, 2020 09:57
@M-i-k-e-l M-i-k-e-l restored the fix/with-scroll-reached-android-threshold branch September 21, 2020 10:00
@M-i-k-e-l M-i-k-e-l deleted the fix/with-scroll-reached-android-threshold branch September 21, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar