Add testID to Hint's Modal background #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Aug 5, 2020
ethanshar
requested changes
Aug 5, 2020
src/components/hint/index.js
Outdated
Comment on lines
361
to
362
| testID={testID} | ||
| testID={`${testID}.animatableView`} | ||
| > |
There was a problem hiding this comment.
Don't change this.
There's always a main element that gets the original testID that the user pass.
Also, changing this is a breaking change cause it will break tests that depend on that.
ethanshar
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add testID on the Modal that renders when onBackgroundPress prop sent in Hint