Fix/button RTL support #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Aug 18, 2020
src/components/button/index.tsx
Outdated
Comment on lines
412
to
419
| getIconStyle() { | ||
| const {disabled, iconStyle: propsIconStyle, iconOnRight} = this.props; | ||
| const {disabled, iconStyle: propsIconStyle, iconOnRight, supportRTL} = this.props; | ||
| const size = this.props.size || DEFAULT_SIZE; | ||
| const shouldFlipRTL = supportRTL && Constants.isRTL; | ||
| const iconStyle: ImageStyle = { | ||
| tintColor: this.getLabelColor() | ||
| tintColor: this.getLabelColor(), | ||
| transform: shouldFlipRTL ? [{scaleX: -1}] : undefined | ||
| }; |
There was a problem hiding this comment.
The Image already supports this feature, why not just pass forward the supportRTL prop
ethanshar
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button is now support RTL which allows users to flip icon inside button.