Skip to content

Reduce padding of top label margin bottom by 1 pixel #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

Reduce padding of top label margin bottom by 1 pixel #900

merged 1 commit into from
Aug 20, 2020

Conversation

Effanuel
Copy link
Contributor

@Effanuel Effanuel commented Aug 18, 2020 •
edited
Loading

gif222

  • Currently coming from a valid state to an error state replaced the top placeholder label with an error message, and moves the whole TextField down because topLabel receives padding that is 1 pixel higher than default.

Fix:

  • Reduced marginBottom height of topLabel by 1.

@Effanuel Effanuel requested a review from ethanshar August 18, 2020 18:35
@ethanshar ethanshar merged commit ea1b2f6 into master Aug 20, 2020
@VernonHawk VernonHawk deleted the Fix-view-bobbing-on-TextField branch August 20, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Effanuel @ethanshar