Skip to content

FloatingButton - Remove UNSAFE method #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2020
Merged

FloatingButton - Remove UNSAFE method #916

merged 3 commits into from
Aug 31, 2020

Conversation

Inbal-Tish
Copy link
Collaborator

FloatingButton - Turning component to a fully controlled component by removing state management.

No breaking changes!

@ethanshar ethanshar self-assigned this Aug 26, 2020
@ethanshar ethanshar requested a review from M-i-k-e-l August 30, 2020 09:06
@ethanshar ethanshar assigned M-i-k-e-l and unassigned ethanshar Aug 30, 2020
M-i-k-e-l
M-i-k-e-l reviewed Aug 30, 2020
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding does not work when withoutAnimation = true

@Inbal-Tish Inbal-Tish requested a review from M-i-k-e-l August 30, 2020 14:50
@M-i-k-e-l
Copy link
Collaborator

Hiding does not work when withoutAnimation = true

I think you've missed this one.

@Inbal-Tish
Copy link
Collaborator Author

@M-i-k-e-l Thanks! Good catch! Fixed.

@M-i-k-e-l M-i-k-e-l merged commit 39a94c0 into master Aug 31, 2020
@Inbal-Tish Inbal-Tish deleted the infra/FloatingButton_remove_UNSAFE branch August 31, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inbal-Tish @M-i-k-e-l @ethanshar