-
Notifications
You must be signed in to change notification settings - Fork 734
Feat/modal migrate to typescript #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/components/modal/index.tsx
Outdated
{ | ||
TopBar: typeof TopBar; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing to typeof Modal
it will automatically pass the type of Modal class with all of its static member.
This is what we do in our Button component, let's see if it works here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I've just now noticed that we send |
Migrate Modal (and dependency) to typescript