Skip to content

Feat/modal migrate to typescript #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 8, 2020
Merged

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Aug 31, 2020

Migrate Modal (and dependency) to typescript

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar September 1, 2020 12:23
@M-i-k-e-l M-i-k-e-l marked this pull request as ready for review September 1, 2020 12:23
Comment on lines 107 to 109
{
TopBar: typeof TopBar;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to typeof Modal it will automatically pass the type of Modal class with all of its static member.
This is what we do in our Button component, let's see if it works here as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@M-i-k-e-l
Copy link
Collaborator Author

I've just now noticed that we send cancelIcon={null} in our ModalScreen to remove the default icon, but null is not actually allowed, should I simply add null as an option with an explanation or do you want to think on a better solution?

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar September 3, 2020 14:19
@ethanshar ethanshar merged commit 323c02b into master Sep 8, 2020
@M-i-k-e-l M-i-k-e-l deleted the feat/modal-migrate-to-typescript branch October 19, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants