Skip to content

Migrate panning views to typescript #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 8, 2020
Merged

Migrate panning views to typescript #923

merged 28 commits into from
Sep 8, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

This is a big one, sorry...
There are some TS errors that I'd appreciate if you take a look at, most of them is simply TS not recognising that there is a default value for a prop and I did not find a way to solve that (and still use defaultProps and not ignore).

@M-i-k-e-l
Rename panningContext from .js to .ts
df31735
@M-i-k-e-l
Rename asPanViewConsumer from .js to .tsx
209bd74
@M-i-k-e-l
Migrate asPanViewConsumer to typescript
de0eefa
@M-i-k-e-l
Rename PanningProvider from .js to .tsx
fa1702a
@M-i-k-e-l
Migrate PanningProvider to typescript
5a9abee
@M-i-k-e-l
Rename panListenerView from .js to .tsx
f361602
@M-i-k-e-l
Migrate PanListenerView to typescript + fixes
0a21843
@M-i-k-e-l
PanListenerView - allow undefined values
9072ba8
@M-i-k-e-l
PanListenerView - allow undefined values (2)
d40d8ed
@M-i-k-e-l
Fix some TS errors
1ae6063
@M-i-k-e-l
Remove onLayout - seems like it's not used
1351b37
@M-i-k-e-l
Rename PanListenerScreen from .js to .tsx
0a4bc94
@M-i-k-e-l
Migrate PanListenerScreen to typescript + renaming + exporting properly
bdd58a4
@M-i-k-e-l
Rename PanResponderView from .js to .tsx
9493ca8
@M-i-k-e-l
Migrate PanResponderView to typescript
3e4e186
@M-i-k-e-l
Rename PanResponderScreen from .js to .tsx
e672f8f
@M-i-k-e-l
Migrate PanResponderScreen to typescript + some fixes
d0aae82
@M-i-k-e-l
Rename PanDismissibleView from .js to .tsx
211d021
@M-i-k-e-l
Migrate PanDismissibleView to typescript + some fixes
eeaf82c
@M-i-k-e-l
Remove comments
2531e9c
@M-i-k-e-l
Rename PanDismissibleScreen from .js to .tsx
abb8740
@M-i-k-e-l
Migrate PanDismissibleScreen to typescript + some fixes
5314673
@M-i-k-e-l
Fix some imports
8f884cb
@M-i-k-e-l
Rename PanGestureView from .js to .tsx
123e7ac
@M-i-k-e-l
Migrate PanGestureView to typescript
e9f49f8
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar September 2, 2020 17:21
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
Approved, but need to fix conflicts first.

@M-i-k-e-l M-i-k-e-l merged commit 3c8d4c5 into master Sep 8, 2020
@ethanshar ethanshar deleted the feat/panning-views-migrate-to-typescript branch September 21, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar