RadioGroup - Replace unsafe method with getDerivedStateFromProps #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Sep 15, 2020
| const {value} = prevState; | ||
| const {initialValue} = nextProps; | ||
|
|
||
| if (_.isUndefined(nextProps.initialValue) || value === initialValue) { |
There was a problem hiding this comment.
Why no turn the component to uncontrolled component? Where the initialValue is literally initial value and not updated through a prop change?
There was a problem hiding this comment.
@Inbal-Tish, Yeah, I though about it, but then we going to lose the use case to let users 'reset' the component value.
I consult with Ethan to have a second opinion and we said that this use-cases should be kept
Inbal-Tish
changed the title
Inbal-Tish
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using now
getDerivedStateFromPropsinstead ofUNSAFE_componentWillReceiveProps