Skip to content

ColorPicker - Remove UNSAFE method #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 11, 2020
Merged

ColorPicker - Remove UNSAFE method #940

merged 14 commits into from
Nov 11, 2020

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Sep 16, 2020 •
edited
Loading

  1. Separating the preview dialog from the component - ColorPickerDialog.
  2. Changing component to 'asBaseComponent' HOC.
  3. Removing UNSAFE method by passing a 'key' prop to the ColorPickerDialog component when 'initialColor' prop changes.
  4. Adding TODO comments for V6 migrations.

ethanshar
ethanshar reviewed Oct 12, 2020
View reviewed changes
@Inbal-Tish Inbal-Tish closed this Oct 15, 2020
@Inbal-Tish
Copy link
Collaborator Author

@ethanshar I don't see a way to update the' initialColor' without turning the component to an uncontrolled component and pass a 'key' prop. Do you have any other suggestions?

@Inbal-Tish Inbal-Tish reopened this Oct 20, 2020
@Inbal-Tish Inbal-Tish changed the title ColorPicker - Turn to an uncontrolled component ColorPicker - Remove UNSAFE method Oct 27, 2020
@Inbal-Tish Inbal-Tish requested a review from ethanshar October 27, 2020 09:15
ethanshar
ethanshar reviewed Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inbal-Tish
Just verifying first. Is this PR should be merged to v6 branch or master?
Also, do we still need the initialColor prop?

@Inbal-Tish
Copy link
Collaborator Author

To master. Yes, the initialColor is sent to the ColorPickerDialog as key to render the preview on the required color.

@ethanshar ethanshar merged commit 5cb6561 into master Nov 11, 2020
@Inbal-Tish Inbal-Tish deleted the infra/ColorPicker_remove_UNSAFE branch November 12, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inbal-Tish @ethanshar