Carousel - remove unsafe method #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Sep 23, 2020
There was a problem hiding this comment.
I pushed a fix to the file code format, I think you formatted it before we fixed .prettierrc config.
Anyway, try to add description to PRs even when seem trivial (unless it's a one line fix)
I won't necessarily be the one that review them and it's important to understand what you fix here and how.
| } | ||
|
|
||
| static getDerivedStateFromProps(nextProps, prevState) { | ||
| const {currentPage, prevProps} = prevState; |
There was a problem hiding this comment.
Is there a reason to keep the whole "prevProps" in state?
Why not just keep the initialPageWidth in state and check against its value.
There was a problem hiding this comment.
I'm using 'pageWidth', 'containerMarginHorizontal', 'loop' for the prevProps and passing them to 'presenter.calcOffset()'
ethanshar
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.