Skip to content

[StackAgregator] added onCollapseChanged / onCollapseWillChanged / disablePresses #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bneigher
Copy link
Contributor

@bneigher bneigher commented Sep 16, 2020

Added the following 2 props to StackAgregator component
onCollapseChanged (fn): hook to respond upstream to the collapse state of the stack aggregator
onCollapseWillChanged (fn): hook to respond upstream to beginning of the collapse animation intent of the stack aggregator
disablePresses (bool) [default: false]: removes the onPress functionality / touchableopacity effect

…onal prop to stack aggregator. nice to respond to whether the stack is collapsed or not
@bneigher bneigher changed the title [StackAgregator] added onCollapsedChange watcher function [StackAgregator] added onCollapsedChange / disablePresses Sep 17, 2020
@bneigher bneigher changed the title [StackAgregator] added onCollapsedChange / disablePresses [StackAgregator] added onCollapsedChanged / onCollapedWillChange / disablePresses Sep 18, 2020
@bneigher bneigher changed the title [StackAgregator] added onCollapsedChanged / onCollapedWillChange / disablePresses [StackAgregator] added onCollapseChanged / onCollapseWillChanged / disablePresses Sep 18, 2020
@Inbal-Tish
Copy link
Collaborator

@bneigher You have 11 lint errors for a missing semicolon. Please fix otherwise it will not pass our CI.

@bneigher
Copy link
Contributor Author

bneigher commented Nov 2, 2020

@Inbal-Tish any updates? Would like change my fork back to the wix head

@stale
Copy link

stale bot commented Jan 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 1, 2021
@bneigher
Copy link
Contributor Author

bneigher commented Jan 1, 2021

@Inbal-Tish :(

@stale stale bot removed the wontfix label Jan 1, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 2, 2021
@bneigher
Copy link
Contributor Author

bneigher commented Mar 3, 2021

Seeing this happen again and again makes me wonder why this is an open source repo? I put time in to add a new feature and it just gets abandoned.

@stale stale bot removed the wontfix label Mar 3, 2021
@ethanshar
Copy link
Collaborator

Hey @bneigher
Apologies.
We appreciate your time and effort in submitting a PR and using our lib.
These are crazy times and things get pushed aside unintentionally.

I will take a look now and update soon.
In the meanwhile, I fixed conflicts locally but I can't push them.
Do you mind fixing them

@ethanshar
Copy link
Collaborator

ethanshar commented Mar 3, 2021

@bneigher
I duplicate the PR with the conflicts fixes.
#1210
Closing this one

@ethanshar ethanshar closed this Mar 3, 2021
@bneigher
Copy link
Contributor Author

bneigher commented Mar 4, 2021

@ethanshar much appreciated. I understand the crazy times an appreciate you adding this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants