Feat/expandable list item new component #943
Conversation
There was a problem hiding this comment.
Few comments on this PR
First, try avoid having an inline style. Always move styles into StyleSheet when possible.
Passing inline style can affect performance.
Second, Regarding the structure of the component. I left some comments.
Let me know if something is not clear..
One last thing.
Notice that when you collapse the component, there's a brief moment where you can still see the children overflow the boundary. Try looking into the overflow style prop in order to fix that..
…b.com/wix/react-native-ui-lib into feat/expandableListItem_new_component
| const {expanded, sectionHeader, children} = props; | ||
|
|
||
| function onValueChange() { | ||
| LayoutAnimation.configureNext({...LayoutAnimation.Presets.easeInEaseOut, duration: 200}); |
There was a problem hiding this comment.
We don't trigger animation or update things during a render.
Render can be triggered for many reasons and that means you'll trigger an animation even when you don't intend to.
For that we use hooks like useEffect. (or lifecycle methods in case you use classes)
| */ | ||
| children?: React.ReactNode; | ||
| /** | ||
| * expandableSection icon color |
There was a problem hiding this comment.
You forgot changing the prop description (:
Description
Add generic expandableSection component that render headerSection element and children as a content of the component.