Infra/color slider group remove unsafe #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Sep 29, 2020
Comment on lines
-24
to
-36
| // static getDerivedStateFromProps(nextProps, prevState) { | ||
| // if (nextProps.color !== Colors.getHexString(prevState.value)) { | ||
| // return {value: Colors.getHSL(nextProps.color)}; | ||
| // } | ||
| // return null; | ||
| // } | ||
|
|
||
| UNSAFE_componentWillReceiveProps(nextProps) { | ||
| if (nextProps.color !== Colors.getHexString(this.state.value)) { | ||
| return {value: Colors.getHSL(nextProps.color)}; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't it break functionality?
There was a problem hiding this comment.
Not when I checked it. Did you have an issue?
There was a problem hiding this comment.
No.
But If I understand correctly..
It supported initializing the color value when passing a different value to the prop. No?
Actually, I think it's better when removed....
merging.
ethanshar
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GradientSlider, ColorSliderGroup, SliderGroup - removing UNSAFE method.
Changelog
SliderGroup, GradientSlider, ColorSliderGroup - removing UNSAFE method.