Skip to content

Change how we extract a component props #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2020
Merged

Change how we extract a component props #951

merged 2 commits into from
Sep 23, 2020

Conversation

ethanshar
Copy link
Collaborator

Description

  • There was an issue in PickerDialog components (ios and android) with the usage of Dialog.extractOwnProps due to the migration to asBaseComponent
  • I added a new methods in Modifiers class - extractComponentProps which should replace extractOwnProps

Changelog

Fix issue with Picker when passing the useNativePicker prop an error was thrown.

@ethanshar ethanshar requested a review from M-i-k-e-l September 23, 2020 08:13
M-i-k-e-l
M-i-k-e-l reviewed Sep 23, 2020
View reviewed changes
@ethanshar ethanshar requested a review from M-i-k-e-l September 23, 2020 11:14
@M-i-k-e-l M-i-k-e-l merged commit c7e1500 into master Sep 23, 2020
@ethanshar ethanshar deleted the fix/Dialog_extractOwnProps branch November 30, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l