Skip to content

Feat/add label support to checkbox #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 26, 2020

Conversation

lidord-wix
Copy link
Contributor

Description

Add label and labelStyle props to checkbox to support passing label to checkbox

Changelog

Add label support to checkbox

Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with the new feature.
The checkbox works only if pressing the label.
Pressing the actual checkbox doesn't trigger value change..

@lidord-wix lidord-wix requested a review from ethanshar October 14, 2020 09:20
@lidord-wix lidord-wix requested a review from ethanshar October 21, 2020 09:40
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there (:
just few last fixes

@lidord-wix lidord-wix requested a review from ethanshar October 25, 2020 09:36
@ethanshar ethanshar merged commit 2738154 into master Oct 26, 2020
@lidord-wix lidord-wix deleted the feat/add_label_support_to_checkbox branch November 17, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants