ThemeManager - Adding deprecation warning for 'setTheme()'. #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Sep 30, 2020
Removing ThemeManager theme colors usage; Setting Colors.primary instead of ThemeManager.primaryColor; Moving TouchableOpacity defaultProps from ThemeManager to the component.
|
@ethanshar I added to this PR the removal of all usages of the ThemeManager global constants. |
ethanshar
reviewed
Oct 12, 2020
ethanshar
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ThemeManager - Adding deprecation warning for 'setTheme()' to start the deprecation process before removing the method on the next major version.
Removing all usages of ThemeManager global constants - 'primaryColor', 'CTA', 'titleColor' etc.
Changelog
ThemeManager - Starting deprecation process for 'setTheme()' method.