Skip to content

Add typings to packaged components #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add typings to packaged components #979

merged 1 commit into from
Oct 14, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Oct 13, 2020 •
edited
Loading

Description

Add typings to packaged components.

  • Keyboards are not handled (they have no typings ATM).

Changelog

Add typings to packaged components (resolves #910)

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar October 13, 2020 11:59
ethanshar
ethanshar approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@ethanshar ethanshar merged commit 03da353 into master Oct 14, 2020
@M-i-k-e-l M-i-k-e-l deleted the infra/add-typings-to-packaged-components branch January 25, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typings to packaged components
2 participants
@M-i-k-e-l @ethanshar