Update statusBarHeight calculation #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Oct 18, 2020
| // override guesstimate height with the actual height from StatusBarManager | ||
| StatusBarManager.getHeight((data: any) => (statusBarHeight = data.height)); | ||
| } | ||
| statusBarHeight = StatusBarManager.HEIGHT || 0; // So there will be a value for any case |
There was a problem hiding this comment.
Why not apply the old logic instead of setting to 0 in case 'StatusBarManager.HEIGHT' returns null/undefined?
There was a problem hiding this comment.
Technically it works. We don't even need the 0 for that matter.
Hmm The reason I didn't kept the old logic is cause I would prefer to remove it eventually if everything goes well.
Inbal-Tish
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I Simplified the logic for setting statusBarHeight constants.
I noticed that the previous logic created flakiness with the layout of
Modal.TopBarcomponent.My guess is that in earlier versions of react-native it was more complicated to extract this value, but now
It seems like
NativeModules.StatusBarManagerinitially return the correct value for all platforms (checked iPhoneX, 8, iPad and Android)Anyway, kept the old logic in a comment in case I missed something and in case we'll get a weird issue in the near future.
Changelog
Fix statusBarHeight constant value and how it affect Modal.TopBar layout.