Skip to content

Add appropriate deprecate warnings for picker API #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

ethanshar
Copy link
Collaborator

Description

  • Added migration warning for stop using object for Picker's value prop.
  • Added migration warning for passing value and label props separately for Picker.Item
  • Added an example for a migrated picker in PickerScreen to verify we support correctly the new API and still doesn't break the old API (by keeping the old examples)

Changelog

Migrate Picker component's API. Should pass only string|number for value prop
Migrate Picker.Item component's API. Should pass value and label props separately.

@ethanshar ethanshar requested a review from Inbal-Tish October 19, 2020 07:01
@Inbal-Tish Inbal-Tish merged commit 3dc160d into master Oct 19, 2020
@ethanshar ethanshar deleted the infra/PickerMigration branch March 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants