Lazy #65
Merged
Lazy #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboehm-xdev
reviewed
Apr 22, 2024
...main/java/software/xdev/spring/data/eclipse/store/exceptions/LazyNotUnlinkableException.java
Show resolved
Hide resolved
| @SuppressWarnings("unchecked") | ||
| private Lazy<T> createNewDefaultLazyWithClearableReference() | ||
| { | ||
| Objects.requireNonNull(this.loader); |
There was a problem hiding this comment.
Maybe move those requireNonNull lines to constructor?
There was a problem hiding this comment.
This is not valid. In the constructor it is valid to leave the loader to null (hence the other constructors). But the method is not allowed to get executed when the loader is null.
...java/software/xdev/spring/data/eclipse/store/repository/lazy/SpringDataEclipseStoreLazy.java
Outdated
Show resolved
Hide resolved
.../xdev/spring/data/eclipse/store/repository/lazy/SpringDataEclipseStoreLazyBinaryHandler.java
Outdated
Show resolved
Hide resolved
.../xdev/spring/data/eclipse/store/repository/lazy/SpringDataEclipseStoreLazyBinaryHandler.java
Outdated
Show resolved
Hide resolved
.../xdev/spring/data/eclipse/store/repository/lazy/SpringDataEclipseStoreLazyBinaryHandler.java
Show resolved
Hide resolved
.../xdev/spring/data/eclipse/store/repository/lazy/SpringDataEclipseStoreLazyBinaryHandler.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.