Skip to content

Set the start to 0 on export #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Set the start to 0 on export #118

merged 3 commits into from
Nov 5, 2020

Conversation

nmfzone
Copy link
Contributor

@nmfzone nmfzone commented Nov 5, 2020

If we don't set the start to 0, if we're press the export button from page > 1, and we're displaying row index, the row index will completely wrong.

If we don't set the start to 0, if we're press the export button from page > 1, the row index will completely wrong.
@yajra yajra merged commit e306de6 into yajra:4.0 Nov 5, 2020
@yajra
Copy link
Owner

yajra commented Nov 5, 2020

Good catch! Released on v4.10.2 🚀 Thanks!

@nmfzone
Copy link
Contributor Author

nmfzone commented Nov 5, 2020

Awesome, since I need this asap 👍

@nmfzone nmfzone deleted the patch-1 branch November 5, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants