Skip to content

[4x.] Fix addScopes method pushing the array of scopes. #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2021
Merged

[4x.] Fix addScopes method pushing the array of scopes. #133

merged 3 commits into from
Jul 1, 2021

Conversation

mariovalney
Copy link
Contributor

@mariovalney mariovalney commented Jul 1, 2021

Hi!

I'm trying to use the addScopes in a base class, but sounds like it's creating a array of array of scopes and not a list of scopes like in multiple calls of addScope.

BTW thanks for the package. I love it.

yajra and others added 3 commits October 31, 2020 18:01
* 4.0:
  Bump v4.10.1 🚀
  added space after if and before '('
  added support for Laravel 8.x if Models directory exists then use Models directory in namespace for model
  Add Laravel DataTables 9.x on requirements
@yajra yajra changed the base branch from master to 4.0 July 1, 2021 02:51
@yajra yajra changed the title Fix addScopes method pushing the array of scopes [4x.] Fix addScopes method pushing the array of scopes. Jul 1, 2021
@yajra yajra merged commit e07f36c into yajra:4.0 Jul 1, 2021
@yajra
Copy link
Owner

yajra commented Jul 1, 2021

Released on v4.13.1 🚀 Thanks!

@mariovalney mariovalney deleted the patch-1 branch July 1, 2021 03:34
@mariovalney
Copy link
Contributor Author

Oh. That was fast haha
Thanks!

@lk77
Copy link
Contributor

lk77 commented Jul 27, 2021

my bad, that method never worked as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants