Package maatwebsite/excel still being installed when you want to use fast-excel (or another Excel-package)
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated master branch and let's release this to v5 to avoid any breaking change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When you want to use the
fast-excelpackage (or another Excel-package) instead ofmaatwebsite/excel, this package will be still installed due it's being installed in the root-required selection.It's better to move
maatwebsite/excelto the suggest selection, so we can pick-up one of the suggestions instead.Technically this /is/ a breaking change, but I don't know which branch you are using for v5, since master is little bit behind already.