Fixes some issues and confusion of datatable generator command #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good day @yajra. I feel like there are lot of changes within a single pull request. First I thought let's fix this portion only, then it led to another, then another, and I end up making all the changes in one commit. Also there are some changes I think related to styles that your GitHub actions identified during my first pull request. If you could manage some time to look, do suggest me any changes needed. |
|
Good day @rahulhaque, no problem with the changes. Will review this as soon as I can. Thanks! |
yajra
approved these changes
Nov 15, 2022
|
Released on v9.1.3, thanks a lot! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes plethora of issues for the
datatables:makecommand -datatables:makecommand fail to generate error free classes for the following scenarios where it can't identify the model name and namespace correctly -php artisan datatables:make Api/DriverDataTablephp artisan datatables:make Api/Driverdatatablephp artisan datatables:make Api/Driverphp artisan datatables:make Api/DriverDataTable --model=Driverphp artisan datatables:make Api/DriverDataTable --model=Driver --model-namespace=App\\Customphp artisan datatables:make Api/DriverDataTable --builderDataTablewith mix-case or lowercase generating different class name.datatables:makecommand, thegetModel()method was too confusing. Tried to simplify the logic and removed code duplication. Such as, there's no need to check for -Modelsdirectory anddatatables:make --buildercommand will always fail to create HTML builder class.