Windows CMake directory install fix #1434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yhirose @sum01
Thanks for your initial work on #470
There is a comment which seems to be the rational behind the different CMake installation directory, but I don't think it is relevant (issue: #287)
I therefore assume that this initial split in installation directory was done "from spec", not from practical issue bubbling up - but it's not (was not) correct.
Proposed are two commits.
lib/cmake/[project]/
path - I've integrated many CMake dependencies to date in various projects (one bigger being https://github.com/luxonis/depthai-core) and have never seen this installation path used by any dependency on Windows. Never had issues before.Issue popped up during integration of the library using Hunter package manager.