-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Support CTest #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CTest #1468
Conversation
Add HTTPLIB_TEST option Downlaod GoogleTest source using FetchContent module Generate cert files to test httplib with OpenSSL
Testing with sudo apt install -y libssl-dev libbrotli-dev zlib1g-dev |
For some reason, generating PS. tests in CI sometimes fail due to network issues. |
@jimmy-park, thanks for the pull request. I found some embedded strings, 1) physical paths such as I actually don't maintain any CMake related files. @sum01 kindly takes care of those files, so that I don't need to worry about it. Could you willingly take a responsibility to maintain Thanks for your understanding! |
@yhirose Thanks for replying.
Since
We can choose the latest main branch using I saw comments and understand what you are concerned about. I'm willing to maintain Thanks for the useful library 😄 |
@jimmy-park thanks for the answers, and accept maintaining it! As you mentioned, could you try to use Google Test from the latest main branch? |
@yhirose Sure! |
@jimmy-park, thanks for the fine contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late review, but I wasn't notified about this patch until the 0.12.0 release.
Mostly minor issues/suggestions
@jimmy-park could you replay to @Tachi107's comments and suggestions? |
@jimmy-park yes, please go ahead to make another pull request for the adjustments. Thanks! |
* Add test/CMakeLists.txt to enable testing with CTest Add HTTPLIB_TEST option Downlaod GoogleTest source using FetchContent module Generate cert files to test httplib with OpenSSL * Generate cert2.pem with a new certificate request * Use the latest GoogleTest library
I added
test/CMakeLists.txt
because the current testing workflow is separate from the CMake build system.Now we can do this for testing in a cross-platform way.
I also tested
httplib
withOpenSSL
as shown intest/Makefile
.This requires me to generate some cert files in the build directory.
Here is results on my machine (Windows 10)
It may test with
Brotli
andzlib
as well if libraries are installed correctly.