Skip to content

Reuse gtest on system #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Reuse gtest on system #1493

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
802ff9f
Reuse gtest on the system
pemensik Feb 13, 2023
08140ac
Set CMP0135 only when using FetchContent
jimmy-park Feb 14, 2023
0ac54d4
Add /bigobj option for MSVC
jimmy-park Feb 14, 2023
da84797
Support also cmake between 3.14 and 3.20
pemensik Mar 3, 2023
7e02e34
Remove redundant variable checking
jimmy-park Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,31 @@
cmake_policy(SET CMP0135 NEW)
find_package(GTest)

include(FetchContent)
include(GoogleTest)
if(GTest_FOUND)
if(NOT TARGET GTest::gtest_main AND TARGET GTest::Main)
# CMake <3.20
add_library(GTest::gtest_main INTERFACE IMPORTED)
target_link_libraries(GTest::gtest_main INTERFACE GTest::Main)
Comment on lines +6 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you create an ALIAS library instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, before CMake 3.18, we can not use ALIAS target for GTest::Main that is a non-global IMPORTED library target.

https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries:~:text=New%20in%20version%203.18%3A%20An%20ALIAS%20can%20target%20a%20non%2DGLOBAL%20Imported%20Target.%20Such%20alias%20is%20scoped%20to%20the%20directory%20in%20which%20it%20is%20created%20and%20below.%20The%20ALIAS_GLOBAL%20target%20property%20can%20be%20used%20to%20check%20if%20the%20alias%20is%20global%20or%20not.

endif()
else()
if(POLICY CMP0135)
cmake_policy(SET CMP0135 NEW)
endif()

set(BUILD_GMOCK OFF)
set(INSTALL_GTEST OFF)
set(gtest_force_shared_crt ON)
include(FetchContent)

FetchContent_Declare(
gtest
URL https://github.com/google/googletest/archive/main.tar.gz
)
FetchContent_MakeAvailable(gtest)
set(BUILD_GMOCK OFF)
set(INSTALL_GTEST OFF)
set(gtest_force_shared_crt ON)

FetchContent_Declare(
gtest
URL https://github.com/google/googletest/archive/main.tar.gz
)
FetchContent_MakeAvailable(gtest)
endif()

add_executable(httplib-test test.cc)
target_compile_options(httplib-test PRIVATE "$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")
target_compile_options(httplib-test PRIVATE "$<$<CXX_COMPILER_ID:MSVC>:/utf-8;/bigobj>")
target_link_libraries(httplib-test PRIVATE httplib GTest::gtest_main)
gtest_discover_tests(httplib-test)

Expand Down