Skip to content

content provider: add result callback to content provider #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ottigeda
Copy link
Contributor

to learn if the server did successfully complete a client-request or not.

As a follow up to my question in #930, I tried to come up with a solution for it.

to learn if the server did successfully complete a client-request or not.
@yhirose
Copy link
Owner

yhirose commented May 28, 2021

@ottigeda, thanks for the pull request, but unfortunately the code looks problematic... It doesn't guarantee that the callback is really called in all the situations. You have to care for all the methods (not only write_response_with_content, but write_response) which end up calling write_content_with_provider.

Anyway, I understand fully what you really wanted to do in #930. I'll ponder over how I can implement it. Thanks for your attempt!

@yhirose yhirose closed this May 28, 2021
yhirose added a commit that referenced this pull request Jun 2, 2021
yhirose added a commit that referenced this pull request Jun 2, 2021
ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants