Skip to content

wxwidgets compatibility #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021
Merged

wxwidgets compatibility #964

merged 1 commit into from
Jun 17, 2021

Conversation

simon-edlund
Copy link
Contributor

operator""_ replaced by operator""_t

My compiler (cl.exe 19.28.29334, VS2019, with /std:c++17) does not like the ""_ , using ""_t works better

operator""_ replaced by operator""_t
@simon-edlund
Copy link
Contributor Author

Further investigation revealed that in wxwidgets, someone decided to steal the underscore:

#define _(s) wxGetTranslation((s))

Which destroys the operator""_ in httplib. So I shall not blame the compiler.

Anyway, the proposed change makes cpphttplib compatible with wxwidgets, take it or leave it :-)

@simon-edlund simon-edlund changed the title Update httplib.h wxwidgets compatibility Jun 17, 2021
@yhirose yhirose closed this Jun 17, 2021
@yhirose yhirose reopened this Jun 17, 2021
@yhirose
Copy link
Owner

yhirose commented Jun 17, 2021

@simonedlund, thanks for the suggestion. I have just merged.

@yhirose yhirose merged commit d903053 into yhirose:master Jun 17, 2021
ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
operator""_ replaced by operator""_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants