When -o stdout, keep stdout clean by sending non-help output to stderr instead, as requested in hsutter#615

Author: hsutter

regression-tests/test-results/version

@@ -1,5 +1,5 @@
 
-cppfront compiler v0.2.1   Build 8828:1624
+cppfront compiler v0.2.1   Build 8829:1248
 Copyright(c) Herb Sutter   All rights reserved
 
 SPDX-License-Identifier: CC-BY-NC-ND-4.0

source/build.info

@@ -1 +1 @@
-"8828:1624"
+"8829:1248"

source/cppfront.cpp

@@ -6082,7 +6082,9 @@ auto main(
     int exit_status = EXIT_SUCCESS;
     for (auto const& arg : cmdline.arguments())
     {
-        std::cout << arg.text << "...";
+        auto& out = flag_cpp1_filename != "stdout" ? std::cout : std::cerr;
+
+        out << arg.text << "...";
 
         //  Load + lex + parse + sema
         cppfront c(arg.text);
@@ -6094,25 +6096,25 @@ auto main(
         if (c.had_no_errors())
         {
             if (!c.has_cpp1()) {
-                std::cout << " ok (all Cpp2, passes safety checks)\n";
+                out << " ok (all Cpp2, passes safety checks)\n";
             }
             else if (c.has_cpp2()) {
-                std::cout << " ok (mixed Cpp1/Cpp2, Cpp2 code passes safety checks)\n";
+                out << " ok (mixed Cpp1/Cpp2, Cpp2 code passes safety checks)\n";
             }
             else {
-                std::cout << " ok (all Cpp1)\n";
+                out << " ok (all Cpp1)\n";
             }
 
             if (flag_verbose) {
-                std::cout << "   Cpp1: " << count.cpp1_lines << " lines\n";
-                std::cout << "   Cpp2: " << count.cpp2_lines << " lines";
+                out << "   Cpp1: " << count.cpp1_lines << " lines\n";
+                out << "   Cpp2: " << count.cpp2_lines << " lines";
                 if (count.cpp1_lines + count.cpp2_lines > 0) {
-                    std::cout << " (" << 100 * count.cpp2_lines / (count.cpp1_lines + count.cpp2_lines) << "%)";
+                    out << " (" << 100 * count.cpp2_lines / (count.cpp1_lines + count.cpp2_lines) << "%)";
                 }
-                std::cout << "\n";
+                out << "\n";
             }
 
-            std::cout << "\n";
+            out << "\n";
         }
         //  Otherwise, print the errors
         else

source/sema.h

@@ -818,7 +818,6 @@ class sema
                 //  initializations on some path(s)
                 else {
                     assert (std::ssize(selection_stack) > 0);
-                    // selection_stack.back().debug_print(std::cout);
 
                     auto true_branches  = std::string{};
                     auto false_branches = std::string{};