eswifi misc fixes #26712
Merged
eswifi misc fixes #26712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2020 17:24
Stop any TCP/UDP client session before starting a new one. Signed-off-by: Loic Poulain <[email protected]>
Use log_strdup() helper for logger string parameters. Signed-off-by: Loic Poulain <[email protected]>
|
Removing DNM, expecting the PR to me merged now. |
jukkar
reviewed
Jul 23, 2020
drivers/wifi/eswifi/Kconfig.eswifi
Outdated
| @@ -22,4 +22,11 @@ config WIFI_ESWIFI_THREAD_PRIO | |||
| This option sets the priority of the esWiFi threads. | |||
| Do not touch it unless you know what you are doing. | |||
|
|
|||
| config WIFI_ESWIFI_SHELL | |||
| bool "esWiFi shell" | |||
| default n | |||
There was a problem hiding this comment.
Value is "n" by default, this line can be omitted
There was a problem hiding this comment.
thanks, fixed now
tbursztyka
approved these changes
Jul 27, 2020
added 2 commits
July 27, 2020 19:20
Add a esWiFi shell for device specific controls. For now used to send at commands. Signed-off-by: Loic Poulain <[email protected]>
There are possible buffer overflows when parsing the ip address and SSID. Ensure that we never overwrite the ip and SSID buffers. Signed-off-by: Loic Poulain <[email protected]>
jukkar
approved these changes
Jul 30, 2020
This was referenced Sep 30, 2020
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.14-branch v1.14-branch
# Navigate to the new working tree
cd .worktrees/backport-v1.14-branch
# Create a new branch
git switch --create backport-26712-to-v1.14-branch
# Cherry-pick the merged commits of this pull request and resolve the conflicts
git cherry-pick 40e2d94bc88ac17a3e96bb95d08f1a21c9c6976f~4..40e2d94bc88ac17a3e96bb95d08f1a21c9c6976f
# Push it to GitHub
git push --set-upstream origin backport-26712-to-v1.14-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.14-branchThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.