bluetooth: hci_raw: avoid possible memory overflow in bt_buf_get_tx() #42093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function bt_buf_get_tx(), which is used to allocate buffer from fixed-size pool, does not check size argument before copying the data with the length size into fixed-size buffer, wich may not be large enough. Check immediately before copying if the tailroom of the buffer is large enough. Signed-off-by: Johann Fischer <[email protected]>
If HCI packet length is greater than endpoint MPS or currently received data block (over USB), next block could be larger than allocated net_buf buffer. Check buffer tailroom before copying data using net_buf_add_mem(). Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
added
bug
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
jhedberg
approved these changes
Jan 24, 2022
alwa-nordic
approved these changes
Jan 25, 2022
carlescufi
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bluetooth: hci_raw: avoid possible memory overflow in bt_buf_get_tx()
Function bt_buf_get_tx(), which is used to allocate buffer from
fixed-size pool, does not check size argument before copying
the data with the length size into fixed-size buffer, wich may
not be large enough.
Check immediately before copying if the tailroom of the buffer
is large enough.
usb: bluetooth: check buffer tailroom before copying
If HCI packet length is greater than endpoint MPS or currently
received data block (over USB), next block could be larger
than allocated net_buf buffer.
Check buffer tailroom before copying data using net_buf_add_mem().