std.math: add comptime_int handling for power-of-two functions #24059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements handling for
comptime_int
inputs, andiN
inputs, for the functions:std.math.floorPowerOfTwo
std.math.ceilPowerOfTwo
std.math.ceilPowerOfTwoPromote
std.math.ceilPowerOfTwoAssert
Previously, all functions did not handle
comptime_int
s, and additionally theceil-
functions did not handle signed numbers, and asserted the input be positive - this PR changes the assertion to instead be a return of1
.Generally, the current behaviour of the functions in the face of edge cases seems odd: why shouldn't the ceiling functions cope with non-positive inputs? And why does
std.math.floorPowerOfTwo
return0
for a non-positive input: shouldn't that return an error? The existing behaviour of the floor function was not changed, due to it perhaps being dependent on, but it might be worth while rethinking.