std.Build.Watch: key fanotify file descriptors by mount id #24113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since marks are limited to a single filesystem. Context: ziglang#20670 Original pull request: ziglang#20672 Co-authored-by: Maciej 'vesim' Kuliński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's okay to take over the inactive pull request #20672. The patch is very similar but I've taken into account the review comments: since indices correspond between the 'public'
DirTableand 'private' (to the Linux implementation)HandleTableI've stashed the mount point information in there. However, the Windows implementation is quite similar and sharesmarkAllFilesDirtyso I had to add a small edge case, not sure what you'll think of it.I've been using Zig for the past two weeks so apologies if I'm not following conventions. I've tested my change by following the wiki and since I'm on NixOS I'm hitting this problem immediately (same error message as #20670).
Fixes #20670.
Closes #20672.