Allow more operators on bool vectors #24131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielkonge
commented
Jun 9, 2025
| @@ -806,7 +806,7 @@ fn expr(gz: *GenZir, scope: *Scope, ri: ResultInfo, node: Ast.Node.Index) InnerE | |||
| .bool_and => return boolBinOp(gz, scope, ri, node, .bool_br_and), | |||
| .bool_or => return boolBinOp(gz, scope, ri, node, .bool_br_or), | |||
|
|
|||
| .bool_not => return simpleUnOp(gz, scope, ri, node, coerced_bool_ri, tree.nodeData(node).node, .bool_not), | |||
| .bool_not => return simpleUnOp(gz, scope, ri, node, .{ .rl = .none }, tree.nodeData(node).node, .bool_not), | |||
There was a problem hiding this comment.
I could make it work without this update, but from my understanding we should not use coerced_bool_ri here? Please correct me if I am wrong, and I can change it back.
Danielkonge
commented
Jun 9, 2025
src/Sema.zig
Outdated
| return if (val.isUndef(zcu)) .undef_bool else if (val.toBool()) .bool_false else .bool_true; | ||
| const operand_type_tag = operand_type.zigTypeTag(zcu); | ||
| if (val.isUndef(zcu)) { | ||
| return if (operand_type_tag == .bool) .undef_bool else pt.undefRef(operand_type); |
There was a problem hiding this comment.
I was unsure if I should keep .undef_bool here, or just always return pt.undefRef(operand_type)?
Danielkonge
commented
Jun 9, 2025
Danielkonge
commented
Jun 9, 2025
andrewrk
requested changes
Jun 9, 2025
Danielkonge
force-pushed
the
operators-on-bool-vectors
branch
from
cc39452 to
8551b7f
Compare
|
I have cleaned up the PR as suggested now, but I am not sure if you wanted to keep the explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow binary not, binary and, binary or, binary xor, and boolean not operators on vectors of bool and add corresponding tests.
Also update the lang ref to clarify use of operators on vectors.
This closes #24093.