Skip to content

Subscribe to all ZDO cluster callbacks at once #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Sep 18, 2022

As opposed to subscribing to all ZDO responses individually, subscribe to them all with 0xFFFF and filter out the unnecessary ones in software.

This should reduce runtime memory usage.

@codecov-commenter
Copy link

Codecov Report

Base: 98.60% // Head: 98.55% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (6930ccd) compared to base (824c2b2).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #178      +/-   ##
==========================================
- Coverage   98.60%   98.55%   -0.06%     
==========================================
  Files          43       43              
  Lines        3865     3869       +4     
==========================================
+ Hits         3811     3813       +2     
- Misses         54       56       +2     
Impacted Files Coverage Δ
zigpy_znp/zigbee/application.py 94.86% <50.00%> (-0.63%) ⬇️
zigpy_znp/api.py 97.15% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@puddly puddly merged commit 079d0eb into zigpy:dev Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants