This repository was archived by the owner on Jan 14, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Added method getScheduledLocalNotifications() #1466
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fcf12b9
typo
andrewtremblay-pear f0406be
Fix changelog, wrong issue mentioned.
Dallas62 94fcadf
Merge pull request #1070 from andrewtremblay-pear/patch-1
Dallas62 3ecb5ec
getScheduledLocalNotifications for iOS and android
lukebars 7f0a88b
Merge branch 'dev' of https://github.com/lukebars/react-native-push-n…
lukebars 50da5a5
remove changes in whitespaces
lukebars 3822a9b
whitespaces
lukebars a74d919
format android getScheduledLocalNotifications return object to match …
lukebars 0e5ad34
change naming of notification params returned on android, return date…
lukebars e207fa8
add missing getters for notification attributes
lukebars b62b27b
map scheduled local notifications to united return object for both pl…
lukebars 7c0a381
format date for scheduled notifications object
lukebars d904712
bump @react-native-community/push-notification-ios to v1.2.1
lukebars c4865aa
add example button to log scheduled notifications
lukebars ee9b9b7
add docs
lukebars 1c7a196
"@react-native-community/push-notification-ios": "^1.2.2"
lukebars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,11 @@ | |
"ios": "react-native run-ios", | ||
"start": "react-native start", | ||
"test": "jest", | ||
"lint": "eslint ." | ||
"lint": "eslint .", | ||
"pod-install": "cd ios && pod install" | ||
}, | ||
"dependencies": { | ||
"@react-native-community/push-notification-ios": "^1.1.1", | ||
"@react-native-community/push-notification-ios": "^1.2.2", | ||
"react": "16.11.0", | ||
"react-native": "0.62.2", | ||
"react-native-push-notification": "git+https://[email protected]/zo0r/react-native-push-notification.git" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ | |
"url": "git+ssh://[email protected]:zo0r/react-native-push-notification.git" | ||
}, | ||
"dependencies": { | ||
"@react-native-community/push-notification-ios": "^1.2.0" | ||
"@react-native-community/push-notification-ios": "^1.2.2" | ||
}, | ||
"peerDependencies": { | ||
"react-native": ">=0.33" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this line,
I totally agree iOS should have the notification ID, but by default,
userInfo
is set to{}
.Not sure if we need to set a default value on
userInfo
(notificationId
?) or let this field empty when the developer doesn't set it inuserInfo
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why it's optional chained here. It would result in undefined if it is not set. Currently we're using
userInfo.id
for cancelling notifications by id, so it makes sense to me.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But setting the id as default when scheduling the notification would be an awesome feature IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into it, thanks for the PR !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the commit here:
6bcc2a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 🙏