This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Allow HTML tags to be used for styling in bigText field only #2067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a modified and simplifed version of wanderbon's PR that is not yet merged |
|
Hi, |
|
@Dallas62 hi can we merge this? |
|
@Dallas62 hello? |
|
Hi @silencer07 |
|
Thanks @Dallas62 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
bigText field should be allowed to have HTML tags as a way to format the message since this has been already supported in android natively for a long time
Expected behaviour:
Allows a subset of html tags to be used as outlined in this android documentation. Note that if user did not provided a bigText field but added html tags in message it self, it won't work as message field in iOS does not support HTML tags nor iOS has bigText property
Testing:
on bigText field, add some
<br/>tags and see if it will put the subsequent string to the next line in android.Change:
This is a small change, this merely decorates the bigText as Spanned Text