Skip to content

Commit 2a8b6a3

Browse files
committed
lghtbox: translations
1 parent f9f3d9a commit 2a8b6a3

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

assets/l10n/app_en.arb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,14 @@
7575
"@actionSheetShare": {
7676
"description": "Label for share button on action sheet."
7777
},
78+
"lightboxCopyLinkTooltip": "Copy link",
79+
"@lightboxCopyLinkTooltip": {
80+
"description": "Tooltip in lightbox for the copy link action."
81+
},
82+
"lightboxCopyLinkSuccessToast": "Link copied",
83+
"@lightboxCopyLinkSuccessToast": {
84+
"description": "Success message in lightbox after copy link action completed."
85+
},
7886
"subscribedToNStreams": "Subscribed to {num, plural, =0{no streams} =1{1 stream} other{{num} streams}}",
7987
"@subscribedToNStreams": {
8088
"description": "Test page label showing number of streams user is subscribed to.",

lib/widgets/lightbox.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import 'package:flutter/material.dart';
22
import 'package:flutter/services.dart';
3+
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
34
import 'package:intl/intl.dart';
45

56
import '../api/model/model.dart';
@@ -70,12 +71,13 @@ class _CopyLinkButton extends StatelessWidget {
7071

7172
@override
7273
Widget build(BuildContext context) {
74+
final zulipLocalizations = ZulipLocalizations.of(context);
7375
return IconButton(
74-
tooltip: 'Copy link',
76+
tooltip: zulipLocalizations.lightboxCopyLinkTooltip,
7577
icon: const Icon(Icons.copy),
7678
onPressed: () async {
77-
// TODO(i18n)
78-
copyWithPopup(context: context, successContent: const Text('Link copied'),
79+
copyWithPopup(context: context,
80+
successContent: Text(zulipLocalizations.lightboxCopyLinkSuccessToast),
7981
data: ClipboardData(text: url.toString()));
8082
});
8183
}
@@ -136,7 +138,7 @@ class _LightboxPageState extends State<_LightboxPage> {
136138
if (_headerFooterVisible) {
137139
// TODO(#45): Format with e.g. "Yesterday at 4:47 PM"
138140
final timestampText = DateFormat
139-
.yMMMd(/* TODO(i18n): Pass selected language here, I think? */)
141+
.yMMMd(/* TODO(#278): Pass selected language here, I think? */)
140142
.add_Hms()
141143
.format(DateTime.fromMillisecondsSinceEpoch(widget.message.timestamp * 1000));
142144

0 commit comments

Comments
 (0)