test [nfc]: Make addStream async

This is the next step toward making handleEvent async.

Author: gnprice

test/model/compose_test.dart

@@ -237,10 +237,10 @@ hello
         required String name,
         String? topic,
         int? nearMessageId,
-      }) {
+      }) async {
         assert(expectedFragment.startsWith('#'), 'wrong-looking expectedFragment');
         final store = eg.store();
-        store.addStream(eg.stream(streamId: streamId, name: name));
+        await store.addStream(eg.stream(streamId: streamId, name: name));
         final narrow = topic == null
           ? StreamNarrow(streamId)
           : TopicNarrow(streamId, topic);
@@ -340,7 +340,7 @@ hello
     final stream = eg.stream(streamId: 1, name: 'test here');
     final message = eg.streamMessage(sender: sender, stream: stream, topic: 'some topic');
     final store = eg.store();
-    store.addStream(stream);
+    await store.addStream(stream);
     await store.addUser(sender);
 
     check(quoteAndReplyPlaceholder(store, message: message)).equals('''

test/model/message_list_test.dart

@@ -39,8 +39,9 @@ void main() async {
   Future<void> prepare({Narrow narrow = const AllMessagesNarrow()}) async {
     final stream = eg.stream();
     subscription = eg.subscription(stream);
-    store = eg.store()
-      ..addStream(stream)..addSubscription(subscription);
+    store = eg.store();
+    await store.addStream(stream);
+    store.addSubscription(subscription);
     connection = store.connection as FakeApiConnection;
     notifiedCount = 0;
     model = MessageListView.init(store: store, narrow: narrow)
@@ -615,7 +616,7 @@ void main() async {
     test('in StreamNarrow', () async {
       final stream = eg.stream(streamId: 1, name: 'stream 1');
       await prepare(narrow: StreamNarrow(stream.streamId));
-      store.addStream(stream);
+      await store.addStream(stream);
       store.addSubscription(eg.subscription(stream, isMuted: true));
       store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.unmuted);
       store.addUserTopic(stream, 'C', UserTopicVisibilityPolicy.muted);
@@ -659,7 +660,7 @@ void main() async {
     test('in TopicNarrow', () async {
       final stream = eg.stream(streamId: 1, name: 'stream 1');
       await prepare(narrow: TopicNarrow(stream.streamId, 'A'));
-      store.addStream(stream);
+      await store.addStream(stream);
       store.addSubscription(eg.subscription(stream, isMuted: true));
       store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.muted);
 

test/model/stream_test.dart

@@ -42,14 +42,20 @@ void main() {
       )));
     });
 
-    test('added by events', () {
+    test('added by events', () async {
       final stream1 = eg.stream(streamId: 1, name: 'stream 1');
       final stream2 = eg.stream(streamId: 2, name: 'stream 2');
       final store = eg.store();
       checkUnified(store);
-      checkUnified(store..addStream(stream1));
-      checkUnified(store..addStream(stream2));
-      checkUnified(store..addSubscription(eg.subscription(stream1)));
+
+      await store.addStream(stream1);
+      checkUnified(store);
+
+      await store.addStream(stream2);
+      checkUnified(store);
+
+      store.addSubscription(eg.subscription(stream1));
+      checkUnified(store);
     });
   });
 
@@ -132,46 +138,52 @@ void main() {
     });
 
     group('isTopicVisible/InStream', () {
-      test('with policy none, stream not muted', () {
-        final store = eg.store()..addStream(stream1)
-          ..addSubscription(eg.subscription(stream1));
+      test('with policy none, stream not muted', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
+        store.addSubscription(eg.subscription(stream1));
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });
 
-      test('with policy none, stream muted', () {
-        final store = eg.store()..addStream(stream1)
-          ..addSubscription(eg.subscription(stream1, isMuted: true));
+      test('with policy none, stream muted', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
+        store.addSubscription(eg.subscription(stream1, isMuted: true));
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
       });
 
-      test('with policy none, stream unsubscribed', () {
-        final store = eg.store()..addStream(stream1);
+      test('with policy none, stream unsubscribed', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
       });
 
-      test('with policy muted', () {
-        final store = eg.store()..addStream(stream1)
-          ..addSubscription(eg.subscription(stream1))
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+      test('with policy muted', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
+        store.addSubscription(eg.subscription(stream1));
+        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isFalse();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
       });
 
-      test('with policy unmuted', () {
-        final store = eg.store()..addStream(stream1)
-          ..addSubscription(eg.subscription(stream1, isMuted: true))
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
+      test('with policy unmuted', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
+        store.addSubscription(eg.subscription(stream1, isMuted: true));
+        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });
 
-      test('with policy followed', () {
-        final store = eg.store()..addStream(stream1)
-          ..addSubscription(eg.subscription(stream1, isMuted: true))
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.followed);
+      test('with policy followed', () async {
+        final store = eg.store();
+        await store.addStream(stream1);
+        store.addSubscription(eg.subscription(stream1, isMuted: true));
+        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.followed);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });

test/model/test_store.dart

@@ -124,7 +124,7 @@ extension PerAccountStoreTestExtension on PerAccountStore {
     }
   }
 
-  void addStream(ZulipStream stream) {
+  Future<void> addStream(ZulipStream stream) async {
     addStreams([stream]);
   }
 

test/model/unreads_test.dart

@@ -174,10 +174,10 @@ void main() {
       check(model.countInAllMessagesNarrow()).equals(5);
     });
 
-    test('countInStream/Narrow', () {
+    test('countInStream/Narrow', () async {
       final stream = eg.stream();
       prepare();
-      streamStore.addStream(stream);
+      await streamStore.addStream(stream);
       streamStore.addSubscription(eg.subscription(stream));
       streamStore.addUserTopic(stream, 'a', UserTopicVisibilityPolicy.unmuted);
       streamStore.addUserTopic(stream, 'c', UserTopicVisibilityPolicy.muted);

test/widgets/action_sheet_test.dart

@@ -42,7 +42,8 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
   await store.addUser(eg.user(userId: message.senderId));
   if (message is StreamMessage) {
     final stream = eg.stream(streamId: message.streamId);
-    store..addStream(stream)..addSubscription(eg.subscription(stream));
+    await store.addStream(stream);
+    store.addSubscription(eg.subscription(stream));
   }
   final connection = store.connection as FakeApiConnection;
 

test/widgets/content_test.dart

@@ -627,7 +627,7 @@ void main() {
       pushedRoutes.removeLast();
 
       final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
-      store.addStream(eg.stream(name: 'stream'));
+      await store.addStream(eg.stream(name: 'stream'));
       return pushedRoutes;
     }