Skip to content

Commit 9a9db2c

Browse files
gnpricechrisbobbe
gnprice
authored and
chrisbobbe
committed
test [nfc]: Make addUser async
This is the next step toward making handleEvent async.
1 parent eca33f9 commit 9a9db2c

10 files changed

+19
-19
lines changed

‎test/model/autocomplete_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ void main() {
221221
const narrow = AllMessagesNarrow();
222222
final store = eg.store();
223223
for (int i = 0; i < 2500; i++) {
224-
store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
224+
await store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
225225
}
226226
final view = MentionAutocompleteView.init(store: store, narrow: narrow);
227227

@@ -244,7 +244,7 @@ void main() {
244244
const narrow = AllMessagesNarrow();
245245
final store = eg.store();
246246
for (int i = 0; i < 1500; i++) {
247-
store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
247+
await store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
248248
}
249249
final view = MentionAutocompleteView.init(store: store, narrow: narrow);
250250

@@ -278,7 +278,7 @@ void main() {
278278
const narrow = AllMessagesNarrow();
279279
final store = eg.store();
280280
for (int i = 0; i < 1500; i++) {
281-
store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
281+
await store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
282282
}
283283
final view = MentionAutocompleteView.init(store: store, narrow: narrow);
284284

@@ -288,7 +288,7 @@ void main() {
288288

289289
await Future(() {});
290290
check(done).isFalse();
291-
store.addUser(eg.user(userId: 10000, email: '[email protected]', fullName: 'User 10000'));
291+
await store.addUser(eg.user(userId: 10000, email: '[email protected]', fullName: 'User 10000'));
292292
await Future(() {});
293293
check(done).isFalse();
294294
await Future(() {});

‎test/model/compose_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,13 +335,13 @@ hello
335335
.equals('[IMG_2488.png](/user_uploads/2/a3/ucEMyjxk90mcNF0y9rmW5XKO/IMG_2488.png)');
336336
});
337337

338-
test('quoteAndReply / quoteAndReplyPlaceholder', () {
338+
test('quoteAndReply / quoteAndReplyPlaceholder', () async {
339339
final sender = eg.user(userId: 123, fullName: 'Full Name');
340340
final stream = eg.stream(streamId: 1, name: 'test here');
341341
final message = eg.streamMessage(sender: sender, stream: stream, topic: 'some topic');
342342
final store = eg.store();
343343
store.addStream(stream);
344-
store.addUser(sender);
344+
await store.addUser(sender);
345345

346346
check(quoteAndReplyPlaceholder(store, message: message)).equals('''
347347
@_**Full Name|123** [said](${eg.selfAccount.realmUrl}#narrow/stream/1-test-here/topic/some.20topic/near/${message.id}): *(loading message ${message.id})*

‎test/model/internal_link_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Future<PerAccountStore> setupStore({
1919
if (streams != null) {
2020
store.addStreams(streams);
2121
}
22-
store.addUser(eg.selfUser);
22+
await store.addUser(eg.selfUser);
2323
if (users != null) {
2424
await store.addUsers(users);
2525
}

‎test/model/test_store.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,13 @@ class TestGlobalStore extends GlobalStore {
114114
}
115115

116116
extension PerAccountStoreTestExtension on PerAccountStore {
117-
void addUser(User user) {
117+
Future<void> addUser(User user) async {
118118
handleEvent(RealmUserAddEvent(id: 1, person: user));
119119
}
120120

121121
Future<void> addUsers(Iterable<User> users) async {
122122
for (final user in users) {
123-
addUser(user);
123+
await addUser(user);
124124
}
125125
}
126126

‎test/widgets/action_sheet_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
3939

4040
await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
4141
final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
42-
store.addUser(eg.user(userId: message.senderId));
42+
await store.addUser(eg.user(userId: message.senderId));
4343
if (message is StreamMessage) {
4444
final stream = eg.stream(streamId: message.streamId);
4545
store..addStream(stream)..addSubscription(eg.subscription(stream));

‎test/widgets/content_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ void main() {
823823
await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
824824
store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
825825
final user = eg.user(avatarUrl: avatarUrl);
826-
store.addUser(user);
826+
await store.addUser(user);
827827

828828
prepareBoringImageHttpClient();
829829
await tester.pumpWidget(GlobalStoreWidget(

‎test/widgets/emoji_reaction_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ void main() {
2929
await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
3030
store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
3131

32-
store.addUser(eg.selfUser);
32+
await store.addUser(eg.selfUser);
3333

3434
// TODO do this more centrally, or put in reusable helper
3535
final Future<ByteData> font = rootBundle.load('assets/Source_Sans_3/SourceSans3VF-Upright.otf');

‎test/widgets/message_list_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void main() {
5757
connection = store.connection as FakeApiConnection;
5858

5959
// prepare message list data
60-
store.addUser(eg.selfUser);
60+
await store.addUser(eg.selfUser);
6161
await store.addUsers(users ?? []);
6262
assert((messageCount == null) != (messages == null));
6363
messages ??= List.generate(messageCount!, (index) {
@@ -378,8 +378,8 @@ void main() {
378378
eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]),
379379
eg.dmMessage(from: eg.thirdUser, to: [eg.selfUser, eg.otherUser]),
380380
]);
381-
store.addUser(eg.otherUser);
382-
store.addUser(eg.thirdUser);
381+
await store.addUser(eg.otherUser);
382+
await store.addUser(eg.thirdUser);
383383
await tester.pump();
384384
tester.widget(find.text(zulipLocalizations.messageListGroupYouWithYourself));
385385
tester.widget(find.text(zulipLocalizations.messageListGroupYouAndOthers(
@@ -394,7 +394,7 @@ void main() {
394394
eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]),
395395
eg.dmMessage(from: eg.thirdUser, to: [eg.selfUser, eg.otherUser]),
396396
]);
397-
store.addUser(eg.thirdUser);
397+
await store.addUser(eg.thirdUser);
398398
await tester.pump();
399399
tester.widget(find.text(zulipLocalizations.messageListGroupYouAndOthers(
400400
zulipLocalizations.unknownUserName)));

‎test/widgets/profile_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Future<void> setupPage(WidgetTester tester, {
3535
await testBinding.globalStore.add(eg.selfAccount, initialSnapshot);
3636
final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
3737

38-
store.addUser(eg.selfUser);
38+
await store.addUser(eg.selfUser);
3939
if (users != null) {
4040
await store.addUsers(users);
4141
}

‎test/widgets/recent_dm_conversations_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ Future<void> setupPage(WidgetTester tester, {
3333
await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
3434
final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
3535

36-
store.addUser(eg.selfUser);
36+
await store.addUser(eg.selfUser);
3737
for (final user in users) {
38-
store.addUser(user);
38+
await store.addUser(user);
3939
}
4040

4141
for (final dmMessage in dmMessages) {

0 commit comments

Comments
 (0)