Skip to content

check: Ensure GNU coreutils are used on macOS #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

rajveermalviya
Copy link
Member

Without this, there are failures when running ./tools/check script with --verbose flag:

Test command: ./tools/check pigeon --all-files --fix --verbose
date: illegal option -- -
usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
            [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
            [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
Time now:
zulip-flutter e0df0ed10 • 2025-02-26 05:01:14 +0000

@chrisbobbe chrisbobbe requested a review from gnprice February 27, 2025 19:04
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Feb 27, 2025
Without this, there are failures when running `./tools/check`
script with `--verbose` flag:

    Test command: ./tools/check pigeon --all-files --fix --verbose
    date: illegal option -- -
    usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
                [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
                [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
    Time now:
    zulip-flutter e0df0ed • 2025-02-26 05:01:14 +0000
@gnprice
Copy link
Member

gnprice commented Feb 28, 2025

Good catch, thanks.

Merging with one style tweak:

 
 # shellcheck source=tools/lib/ensure-coreutils.sh
 . "${this_dir}"/lib/ensure-coreutils.sh
+
 # shellcheck source=tools/lib/git.sh
 . "${this_dir}"/lib/git.sh
 

I think I'd be happy to have the . … lines right next to each other if they didn't need those # shellcheck … comments; but since they do, it feels a bit easier to read with a blank line there to visually group that comment with the next line rather than the previous.

@gnprice gnprice force-pushed the pr-ensure-coreutils branch from 5e960f7 to 70589a8 Compare February 28, 2025 00:52
@gnprice gnprice merged commit 70589a8 into zulip:main Feb 28, 2025
@rajveermalviya rajveermalviya deleted the pr-ensure-coreutils branch March 5, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants