settings: Upgrade Flutter; migrate to new RadioGroup API

[chrisbobbe]

Fixes: #1545

[rajveermalviya]

Thanks LGTM!

Also, no additional changes to the macOS/iOS Podfile/Podfile.lock when doing flutter run on my side.

[chrisbobbe]

Hmm actually—it looks like the Info.plist thing is a breaking change: flutter/flutter@3d8fa621c

From my reading of the commit and the migration guide linked from there, it looks like it wouldn't break our main but it would interfere with #1379; is that right?

[rajveermalviya]

Right, also looks like the migration/fix for that is going to be a bit involved. (See discussion here: https://discord.com/channels/608014603317936148/1380539391671275662)

Also, I saw a report of deep links being broken, which led me to test the web auth flow in our app on iOS Simulator and unfortunately it turns out that we are affected by it too (verified by switching back and forth between that and the parent commit). I'll file an upstream issue (in a bit, with a reproducer) if the reporter doesn't already have it by then.

Edit: Filed flutter/flutter#170350.

[chrisbobbe]

Thanks for investigating!

[gnprice]

Given the breakage of web auth, let's plan to not upgrade Flutter past that commit until after the launch. (Even if it gets fixed upstream this week, time is getting short before the launch.)

The migration those upstream changes require in #1379 would also be enough to make it tempting to hold off on upgrading until after the launch.

@chrisbobbe Does the upstream change that's needed for the #1545 fix happen before the UIScene breaking change? If so, let's upgrade to that point. If not, we can just put ignore-comments on those deprecation warnings for now, and update #1545 to be about removing those ignore-comments.

[chrisbobbe]

@chrisbobbe Does the upstream change that's needed for the #1545 fix happen before the UIScene breaking change?

Hmm, no, the change needed for #1545 (flutter/flutter@d0058ec36) happens after the UiScene breaking change (flutter/flutter@3d8fa621c):

chrisbobbe:~/dev/flutter (main u-40) 
$ git merge-base --is-ancestor 3d8fa621c d0058ec
chrisbobbe:~/dev/flutter (main u-40) 
$ echo $?
0

So yeah, I'll close this and do this:

If not, we can just put ignore-comments on those deprecation warnings for now, and update #1545 to be about removing those ignore-comments.

[chrisbobbe]

Sent #1562 for that and edited #1545.