KaTeX (3/n): Support negative margins for spans #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajveermalviya Copying here for visibility what you told me on our call today: the reason this is a draft (not ready to merge) is that you're still working on the widget test. Apart from that, you consider it ready to review. |
rajveermalviya
force-pushed
the
pr-tex-content-3
branch
from
c33f5c2 to
6cfcc0d
Compare
This will prevent string interpolation being evaluated during release build. Especially useful in later commit where it becomes more expensive.
This applies the correct font scaling if the KaTeX content is inside a header.
And rename previous type to KatexSpanNode, also while making it a subtype of KatexNode.
In KaTeX HTML it is used to set the baseline of the content in a span, so handle it separately here.
And inline the behaviour for `inline: false` in MathBlock widget.
rajveermalviya
force-pushed
the
pr-tex-content-3
branch
from
6cfcc0d to
843207d
Compare
Implement handling most common types of `vlist` spans.
Negative margin spans on web render to the offset being applied to the specific span and all the adjacent spans, so mimic the same behaviour here.
rajveermalviya
force-pushed
the
pr-tex-content-3
branch
from
843207d to
d1f5d5c
Compare
gnprice
reviewed
Jun 12, 2025
Comment on lines
+39
to
+40
| // Like [RenderPadding] but supports negative values. | ||
| class RenderNegativePadding extends RenderShiftedBox { |
There was a problem hiding this comment.
Let's leave a TODO tracking our intention to get a version of this upstream:
Suggested change
| // Like [RenderPadding] but supports negative values. | |
| class RenderNegativePadding extends RenderShiftedBox { | |
| // Like [RenderPadding] but supports negative values. | |
| // TODO(upstream): give Padding an option to accept negative padding (at cost of hit-testing not working) | |
| class RenderNegativePadding extends RenderShiftedBox { |
Comment on lines
+200
to
+201
| extension on EdgeInsetsGeometry { | ||
| bool get isNegative => !isNonNegative; |
There was a problem hiding this comment.
I think this is clearer (and hardly much longer) if just inlined.
In particular there's some ambiguity in that "is negative" sounds like it might require all the sides to be negative. So being more transparent, with one fewer layer of indirection, helps mitigate that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1452.
Related: #46