Upgrade Flutter and packages (2024-06) #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM except I think a few of these commits have an unintended author field? Please merge at will after looking at that. |
|
Hmm good catch, thanks! Some of them have my personal email instead of my zulip.com email. I don't normally notice that, because we have a Looking with I'll fix those in these commits too, and merge. |
Otherwise this comes immediately after the `git commit` output, so the paragraph blends in undesirably.
This will be convenient for adding a new step that doesn't require CocoaPods. The check is very fast, so unlike with check_pub_get_clean there's no need to memoize the result.
This version leaves it to the user/developer to handle actually upgrading their Flutter install to latest; but it takes care of updating pubspec.yaml and pubspec.lock. The upgrade of the actual Flutter install will presumably look different anyway after zulip#15 / zulip#579, so we leave that to the future.
And update Flutter's supporting libraries to match.
And update generated files to match the `pigeon` upgrade. The `pigeon` change seems pretty innocuous. But just to be sure, I ran the app (with `flutter run --release`) and tested end-to-end that it still receives notifications.
Changelog: https://pub.dev/packages/pigeon/changelog The only breaking change is: Limits the number of total custom types to 126. If more than 126 custom types are needed, consider breaking up your definition files. Which definitely isn't a problem for us! The changes all look pretty innocuous; but just to confirm, I fired up the app (as a release build) and tested end-to-end that notifications still appear. As usual I tested it while the app was in the foreground, in the background, and not running.
This completes `tools/upgrade pub-major`. The documented breaking changes are that they bumped the minimum OS versions: iOS 13, and Android API 21 (Android 5.0 Lollipop). We already have minimums of iOS 14 and Android API 28 (aka Android 9 Pie), so those don't affect us. To confirm nothing broke accidentally either, though: I fired up the app as a release build, on Android, and did the usual end-to-end tests of receiving notifications. Changelogs: https://pub.dev/packages/firebase_core/changelog https://pub.dev/packages/firebase_messaging/changelog
|
I think the reason I noticed it was that my Git graphical client was showing this: 
instead of this, which is usual: 
😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a new feature in
tools/upgradeto partially automate the Flutter upgrade.There are also a couple of packages that have major-version upgrades to take:(edit: done, and added to PR.)pigeon,firebase_core,firebase_messaging. I'll look at those separately as a followup.